Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PWA Precache #831

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix PWA Precache #831

wants to merge 8 commits into from

Conversation

JayJay1024
Copy link
Collaborator

@JayJay1024 JayJay1024 commented Sep 25, 2024

PR-Codex overview

This PR primarily focuses on the removal of numerous asset files and the addition of a new vercel.json configuration file. It also updates the PWABadge component to enhance its functionality and modifies the vite.config.ts to enable PWA support.

Detailed summary

  • Deleted multiple asset files in apps/web/public/assets.
  • Added a new vercel.json with caching and security headers.
  • Updated PWABadge component to conditionally render the reload message.
  • Enabled PWA support in vite.config.ts with specific configurations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 0062127

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JayJay1024
Copy link
Collaborator Author

  1. The root cause is that the entry js resource file is too large, causing the precache of the PWA to fail for this file.
image image image
  1. When deploying a new version, before Reload, the entry html file uses the precache version(ServiceWorker), and the html references the old entry js file. However, since the entry js precache is invalid, it is always read from the server, and the server has been updated to the new version, so the entry js resource file cannot be obtained.
image
  1. We should go deeper into code splitting, but for now we will temporarily increase the file size limit.
image image image image

@JayJay1024 JayJay1024 marked this pull request as ready for review September 25, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant