Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Goa proof of concept #13

Merged
merged 6 commits into from
Jan 19, 2018
Merged

Conversation

thefirstofthe300
Copy link
Contributor

Please feel free to critique the crap out of it. Right now, it has no interaction with a database, partially because I wanted to get this out there for people to start poking at and partly because I know that will take me a while.

I'm using github.com/golang/dep for dependency management since it now has stable toml and lock file formats as well as having the weight of the core Golang team.

Based on my reading, the initial auth flow should be easy enough to spec out with Goa, so that's a plus. Overall, I am liking Goa and think it has most of what we want/need, not that I should be the judge of these things (lack of experience is killer). :P

@thefirstofthe300
Copy link
Contributor Author

So I'm up to having a basic auth scheme implemented. Right now, instead of granting or denying access based on username and password, it will only log the username and password that are passed in the HTTP headers. It's just a matter of logic so I don't see a need to add it for a POC (the concept is proved).

Next up is authorizing and denying access to certain endpoints based on authorization level using JWTs. Given Goa's library support, it seems fairly straightforward.

@thefirstofthe300
Copy link
Contributor Author

With the most recent commit, this is now a full fix for #8.

@thefirstofthe300
Copy link
Contributor Author

This would also partially address #5

@thefirstofthe300
Copy link
Contributor Author

@eriknelson you had a chance to look at this yet?

@eriknelson
Copy link
Member

Haven't had a chance to delve into this in-depth, but going to merge nonetheless. I'm very interested in seeing demos of various relationship types between models and how those work with clients. Could consider that a next step.

@eriknelson eriknelson merged commit 867778a into hegemone:master Jan 19, 2018
@thefirstofthe300
Copy link
Contributor Author

Could you spin this into a new bug for discussion? I'm not quite seeing exactly what you are talking about. Plus, a bug gives me a scratchpad/discussion forum for how to work it out. :)

@eriknelson
Copy link
Member

@thefirstofthe300 yep, will flesh that out in an issue and tag you.

thefirstofthe300 pushed a commit to thefirstofthe300/kore-poc that referenced this pull request Jan 21, 2018
* Rename ruby poc

* Initial korecomm-go commit

* Add README.md and gitignore

* Deps

* Glide & vendor

* Demo implementation

* Docker support

* Full README.md and kick up logging to Info level

Initial commit for Goa Kore data server implementation

Dependency management with dep

Initial goa API with no data base

Add rudimentary database calls

Update to use basic auth

Added JWT authentication with support for scopes

Initial Goa proof of concept (hegemone#13)

* Initial commit for Goa Kore data server implementation

* Dependency management with dep

* Initial goa API with no data base

* Add rudimentary database calls

* Update to use basic auth

* Added JWT authentication with support for scopes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants