Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Add checkbox in view programs page #5764

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Sep 10, 2024

Adds a checkbox in the view programs page, only visible if the user is the teacher of the creator of the program. By ticking the checkbox, the program is stored in the database as reviewed. By going backwards to the table, it'll trigger a reload and the page will be updated. At last, I also added a tick mark in the adventure page, that lets the student know if the teacher reviewed this program.

Fixes #5752

How to test

  1. Log in as a student and run a program in several tabs (can't be the examples, because otherwise it won't be shown in the table)
  2. Now log in as the teacher and go to the class page where the student belongs. Click the eye icon and then tick the checkbox.
  3. The checkbox for this program should be ticked.

Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected! Not approving yet, because I think a console.log statement might have been left in unintentionally

static/js/teachers.ts Outdated Show resolved Hide resolved
@boryanagoncharenko boryanagoncharenko self-assigned this Sep 11, 2024
@Felienne Felienne changed the title 💻 Add checkbox in vie programs page 💻 Add checkbox in view programs page Sep 11, 2024
Copy link
Contributor

mergify bot commented Sep 12, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d262ce0 into main Sep 12, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Sep 12, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the check_box_view_program branch September 12, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

💻 Add tickmark in student exercise
2 participants