Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Adventure page redesign #5648

Draft
wants to merge 115 commits into
base: main
Choose a base branch
from
Draft

💻 Adventure page redesign #5648

wants to merge 115 commits into from

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Jul 2, 2024

@Annelein
Copy link
Collaborator Author

Annelein commented Jul 3, 2024

A few good points that @AnneliesVlaar mentioned in #5517 , I've also added some

Few points of discussion:

  • If the user uses the copy symbol, will the copy symbol (and button) than change into a paste symbol? And what behaviour will it have? Clean and paste? Paste at the end? Paste at the cursor?
  • Do we want the explanation to be smaller in height and thus scrollable?

Missing in the design:

Please leave a comment if there is something else you're missing or that needs to be discussed

Screen.Recording.2024-07-03.at.15.13.08.mov

@Annelein Annelein changed the title 💻 Hedy redesign 💻 Adventure page redesign Jul 3, 2024
@Felienne
Copy link
Member

Felienne commented Jul 4, 2024

  • If the user uses the copy symbol, will the copy symbol (and button) than change into a paste symbol? And what behaviour will it have? Clean and paste?

Ow that is a great idea, I would love a copy button that changes into a paste button on theory. However in practice, no other tool has that (as fas as I know) so I fear it will be more confusing if we do it. We can disable the copy button if something has already been copied? But I also see how we can, for now, just aline with other tools do with is nothing.

Paste at the end? Paste at the cursor?

This is an unrelated interesting question! We have long discussed pasting at the end instead of over for the yellow example buttons. I am fine with that but maybe it is out of scope here? Do we need to discuss that now?

  • Do we want the explanation to be smaller in height and thus scrollable?

Another very hard question!!!! I think it does not look nice that the explanation "hops" when switching tabs. However kids might not care so much? I fear that they will not scroll and then miss important explanation if we don't show it all (but on the other other hand, maybe they never read?)

In conclusion I think I'd keep it as we have it, but I can easily be swayed.

@AnneliesVlaar
Copy link
Contributor

  • If the user uses the copy symbol, will the copy symbol (and button) than change into a paste symbol? And what behaviour will it have? Clean and paste?

Ow that is a great idea, I would love a copy button that changes into a paste button on theory. However in practice, no other tool has that (as fas as I know) so I fear it will be more confusing if we do it. We can disable the copy button if something has already been copied? But I also see how we can, for now, just aline with other tools do with is nothing.

I can see that an all-in-one copy/paste button can be confusing. I was wondering, if you copy your code (to use it in a different level/adventure I guess), how do you paste it there without a paste button. Can we easily teach student to use a button to copy and ctrl+v for example to paste?

Paste at the end? Paste at the cursor?

This is an unrelated interesting question! We have long discussed pasting at the end instead of over for the yellow example buttons. I am fine with that but maybe it is out of scope here? Do we need to discuss that now?

I will make separate issue about the yellow button.

  • Do we want the explanation to be smaller in height and thus scrollable?

Another very hard question!!!! I think it does not look nice that the explanation "hops" when switching tabs. However kids might not care so much? I fear that they will not scroll and then miss important explanation if we don't show it all (but on the other other hand, maybe they never read?)

In conclusion I think I'd keep it as we have it, but I can easily be swayed.

@gisellandrade
Copy link
Collaborator

@Annelein Here's the new buttons for the design and new modifications
image

And also I just add the language buttons that shows this
Captura de pantalla 2024-07-09 093735

@gisellandrade
Copy link
Collaborator

I'm leaving here the drawer, and how it would look like
image
image
image

@jpelay jpelay marked this pull request as draft September 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issue with the web interface
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants