Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ActionController::MissingRenderer from Rails #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zzak
Copy link

@zzak zzak commented May 29, 2023

Happened upon this exception when patching this file in rails/rails#48327, the documentation references a method which was moved to this gem, and nothing else in Rails uses it internally.

I think we can move it here and deprecate it from Rails, which I've started working on in rails/rails#48328

@carlosantoniodasilva
Copy link
Member

@zzak I can get this into responders and released, but we'll have to update the Rails side of things a bit apparently... we might also have to detect here if the constant is not already defined or something (suppressing possible warnings), I think?

@zzak
Copy link
Author

zzak commented Apr 16, 2024

@carlosantoniodasilva Thanks for the ping, yeah I'm not sure but maybe we can do unless defined??

I have to fix the tests (and probably rebase) upstream too, but I think the right thing to do is do the check on responders side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants