Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkeys support: Rename Devise::Strategies::Authenticatable => PasswordAuthenticatable #5531

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tcannonfodder
Copy link

Rename Devise::Strategies::Authenticatable => PasswordAuthenticatable

  • To begin the process of refactoring Devise to support passkeys (Passkeys support #5527), we need to decouple authentication from being specifically tied to passwords.
    • The first step is explicitly prefixing generically-named components like Authenticatable with Password, since they concern password authentication

Add Devise::Strategies::Authenticatable shim w/ deprecation warning

  • To maintain compatability with exisiting installations, we need the Devise::Strategies::Authenticatable class.
    • This re-adds the class in, subclassing from PasswordAuthenticable and printing a deprecation warning

* To begin the process of refactoring Devise to support passkeys, we
	need to decouple authentication from being specifically tied to
	passwords.
	* The first step is explicitly prefixing generically-named components
		like `Authenticatable` with `Password`, since they concern password
		authentication
* To maintain compatability with exisiting installations, we need the
	`Devise::Strategies::Authenticatable` class.
	* This re-adds the class in, subclassing from `PasswordAuthenticable`
		and printing a deprecation warning
tcannonfodder and others added 6 commits October 26, 2022 20:16
* To begin the process of refactoring Devise to support passkeys, we
	need to decouple authentication from being specifically tied to
	passwords.
	* The first step is explicitly prefixing generically-named components
		like `Authenticatable` with `Password`, since they concern password
		authentication
* To maintain compatability with exisiting installations, we need the
	`Devise::Strategies::DatabaseAuthenticatable` class.
	* This re-adds the class in, subclassing from
		`DatabasePasswordAuthenticable` and printing a deprecation warning
* To begin the process of refactoring Devise to support passkeys, we
	need to decouple authentication from being specifically tied to
	passwords.
	* The first step is explicitly prefixing generically-named components
		like `Authenticatable` with `Password`, since they concern password
		authentication
* To maintain compatability with exisiting installations, we need the
	`Devise::Strategies::Rememberable` class.
	* This re-adds the class in, subclassing from `PasswordRememberable`
		and printing a deprecation warning
…with-password

2022 10 26 finish prefixing with password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant