Fix the issue that causes the 'registration' event not to be triggered #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'The operation couldn’t be completed. No APNS token specified before fetching FCM Token' when calling the init method of the plugin. This occurs because initRegistration is executed before registerForRemoteNotifications when the push permissions are already granted.
9 tasks
erisu
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Thank you for the PR.
Could you test and confirm if PR #285 resolves this issue?
I've refactored the initialization process, which I believe corrected the timing issue with FCM. This should eliminate the need for adding a delay, as seen in this PR. Adding a delay might not always provide a consistent or accurate solution, whereas the refactor should ensure proper timing without relying on arbitrary delays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed an issue after upgrading the Firebase iOS messaging SDK to the latest version (10.29.0). The "registration" event wasn't triggered anymore when the app starts.
This issue arises because the initRegistration method fails with the error 'The operation couldn’t be completed. No APNS token specified before fetching FCM Token' when calling the init method of the plugin. This occurs because initRegistration is executed before registerForRemoteNotifications when the push permissions are already granted.
We tested this fix in local and production and everything works as expected.