Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add registry flag to sync cli to match annotation functionality #188

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

amartin120
Copy link
Contributor

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

  • We previously added the registry flag to the image spec manifest but we also need the same flag on the sync cli itself. This PR is for that. Same behavior as the registry annotation.

What is the current behavior?

  • registry override currently only as an annotation.

What is the new behavior (if this is a feature change)?

  • registry override also added as a flag to the sync command.

image

Does this PR introduce a breaking change?

Other information:

@amartin120 amartin120 merged commit 1b9d057 into hauler-dev:main Feb 22, 2024
1 check passed
@amartin120 amartin120 self-assigned this Feb 22, 2024
@amartin120 amartin120 deleted the registry-flag branch March 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant