Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic / Auth Flag Fix / Sync Cleanup #140

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

amartin120
Copy link
Contributor

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

  • adds retry logic for images
  • ensures that the auth flags work for registries
  • stop flushing the store at the start of each sync to take advantage of caching in situations where you need to re-run a manifest.

What is the current behavior?

  • Currently if Hauler fails adding an image to the store, execution stops after 1 attempt. This can be frustrating when you're processing hundreds of images and have a network hiccup.
  • Currently Hauler will not pass auth flags to a registry, forcing you to docker/cosign login prior to Hauler execution.
  • Currently Hauler will completely remove its store and starts fresh for every hauler store sync. While I understand the initial intent, this will not allow for mutliple manifests, or perhaps more importantly, it forces you to start from the beginning if you need to rerun a manifest because of an unforeseen error halfway through processing.

What is the new behavior (if this is a feature change)?

  • see the list of changes above.

Does this PR introduce a breaking change?

  • Not that I've found yet. 👍🏻

Other information:

@amartin120 amartin120 changed the title Multiple Retry logic / Auth Flag Fix / Sync Cleanup Retry logic / Auth Flag Fix / Sync Cleanup Nov 30, 2023
@amartin120 amartin120 merged commit c04211a into hauler-dev:main Nov 30, 2023
1 check passed
@amartin120 amartin120 deleted the retry-logic branch December 4, 2023 16:22
@amartin120 amartin120 restored the retry-logic branch December 4, 2023 16:22
@amartin120 amartin120 deleted the retry-logic branch February 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants