Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI hauler manifests. #136

Merged
merged 12 commits into from
Nov 3, 2023
Merged

Add OCI hauler manifests. #136

merged 12 commits into from
Nov 3, 2023

Conversation

amartin120
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Allows for carbide flavored hauler manifest to be utilized in an "easy button" format.

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    hauler store sync --product rancher:v2.78

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Copy link
Member

@zackbradys zackbradys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments and suggested changes... feel free to take them or leave them!

cmd/hauler/cli/store/sync.go Outdated Show resolved Hide resolved
cmd/hauler/cli/store/sync.go Outdated Show resolved Hide resolved
pkg/artifacts/file/getter/getter_test.go Outdated Show resolved Hide resolved
pkg/artifacts/file/getter/getter_test.go Outdated Show resolved Hide resolved
pkg/consts/consts.go Outdated Show resolved Hide resolved
@dweomer dweomer merged commit 4d950f7 into main Nov 3, 2023
1 check passed
@amartin120 amartin120 deleted the oci-hauler-manifests branch November 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants