Mark fields "allowed_ips" and "client_allowed_ips" as required #315
Conversation
The add-on refuses to start without them. This fixes hassio-addons#262
WalkthroughThe update to Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- wireguard/DOCS.md (2 hunks)
Additional context used
LanguageTool
wireguard/DOCS.md
[style] ~3-~3: As an alternative to the over-used intensifier ‘extremely’, consider replacing this phrase.
Context: ...: WireGuard [WireGuard®][wireguard] is an extremely simple yet fast and modern VPN that utilizes s...
[misspelling] ~13-~13: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’.
Context: ...d) and widely deployable, including via an Hass.io add-on! WireGuard is currently...
[style] ~22-~22: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...minology used. The add-on takes care of a lot of things for you (if you want). Follow t...
[style] ~58-~58: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...however, one big difference: The add-on is able to generate configurations for the add-on,...
[grammar] ~122-~122: An auxiliary verb seems to be missing from this progressive structure. Did you mean “it's effectively making”, “it is effectively making”, or “it was effectively making”?
Context: ...r clients to use those. What this does, it effectively making your clients to have ad-filtering (e.g....
[uncategorized] ~169-~169: Did you mean: “By default,”?
Context: ...o"off", will disable that behavior. By default it executes the following: ```bash ipt...
[uncategorized] ~186-~186: Did you mean: “By default,”?
Context: ...o"off", will disable that behavior. By default it executes the following: ```bash ipt...
[grammar] ~246-~246: A determiner may be missing.
Context: ...n can generate public/private keypairs, from best security practice perspective, it is st...
[style] ~247-~247: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to provide’). Try moving the adverb to avoid split infinitives.
Context: ...ty practice perspective, it is strongly advised to manually provide a public key for each of your peers. In that case, t...
[uncategorized] ~290-~290: Did you mean: “By default,”?
Context: ...tent keepalive interval of 25 seconds. By default or when unspecified, this option is set...
[uncategorized] ~302-~302: Possible missing comma found.
Context: ...onnect to its peer. This is completely optional as the endpoint will be updated automat...
[style] ~308-~308: This phrase might be redundant. Consider either removing or replacing the adjective ‘additional’.
Context: ...y generated bywg genpsk. This option adds an additional layer of symmetric-key cryptography to be mix...
[uncategorized] ~327-~327: Loose punctuation mark.
Context: ...n issue. Possible values are: -trace: Show every detail, like all called inte...
[uncategorized] ~328-~328: Loose punctuation mark.
Context: ...all called internal functions. -debug: Shows detailed debug information. - `in...
[uncategorized] ~329-~329: Loose punctuation mark.
Context: ...ows detailed debug information. -info: Normal (usually) interesting events. - ...
[uncategorized] ~330-~330: Loose punctuation mark.
Context: ...usually) interesting events. -warning: Exceptional occurrences that are not er...
[uncategorized] ~331-~331: Loose punctuation mark.
Context: ...currences that are not errors. -error: Runtime errors that do not require imme...
[uncategorized] ~332-~332: Loose punctuation mark.
Context: ... not require immediate action. -fatal: Something went terribly wrong. Add-on b...
[uncategorized] ~356-~356: When ‘start-up’ is used as a noun or modifier, it needs to be hyphenated.
Context: ...-on to throw a large warning during the start up. However, the add-on will work as adver...
[uncategorized] ~359-~359: The preposition ‘to’ seems more likely in this position.
Context: ...hen this happens, the add-on falls back on a standalone instance of WireGuard runn...
[style] ~362-~362: Consider a shorter alternative to avoid wordiness.
Context: ...has drawbacks in terms of performance. In order to run WireGuard optimal, you should insta...
[style] ~422-~422: ‘take into account’ might be wordy. Consider a shorter alternative.
Context: ...sistant Backups. There is one caveat to take into account: A partial backup of the add-on DOES NO...
[style] ~446-~446: For conciseness, consider replacing this expression with an adverb.
Context: ...esource: http://a0d7b954-wireguard ``` At this moment, we do not have template or examples on...
[uncategorized] ~462-~462: Possible missing preposition found.
Context: ...n add172.30.32.1as a DNS IP address the list to use it. - If you run a protecti...
[uncategorized] ~485-~485: Loose punctuation mark.
Context: ...ented based on the following: -MAJOR: Incompatible or major changes. - `MINOR...
[uncategorized] ~486-~486: Loose punctuation mark.
Context: ...Incompatible or major changes. -MINOR: Backwards-compatible new features and e...
[uncategorized] ~487-~487: Loose punctuation mark.
Context: ...new features and enhancements. -PATCH: Backwards-compatible bugfixes and packa...
|
@coderabbitai, if you're so smart, please also add the label |
|
Tip For best results, initiate chat on the files or code changes. @thijzert, it seems that I currently do not have the necessary permissions to add labels to the PR. You might need to add the label Analysis chainScripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Adding the label 'documentation' to PR #315
gh pr edit 315 --add-label "documentation"
Length of output: 123 Permission issueThere was a permission issue. Please ask the repository administrator to refresh CodeRabbit's permissions at https://github.com/apps/coderabbitai/installations/50882955. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Does this count as "further activity"? |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
@frenck It feels almost impolite to keep bumping my own PR every month. Could you maybe dial down the settings for the auto-stale bot? |
github-actions
bot
removed
the
stale
The add-on refuses to start without them. This fixes #262
Summary by CodeRabbit
peers.allowed_ipsandpeers.client_allowed_ipsin server and client configurations by removing the (optional) tag.