-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and unify --keep-temp-files
#10292
base: master
Are you sure you want to change the base?
Expand and unify --keep-temp-files
#10292
Conversation
69f0104
to
1e05052
Compare
One concern I have is that I don't fully understand how the I'm not objecting to this PR (which I am happy to see), but I would like to make sure that you have taken into consideration the logical separation between the Cabal library and |
Yes, I wasn't entirely sure where to put this flag. There seem to be a lot of flags that are shared between multiple commands (like I picked |
1e05052
to
e0ea1a0
Compare
Currently, `cabal repl` has a `--keep-temp-files` option, and `cabal.project` has a `keep-temp-files` option but it only effects Haddock builds. This patch adds `--keep-temp-files` to `CommonSetupFlags`, making it available to all commands. The expanded `--keep-temp-files` flag is used for the `cabal repl` command and Haddock builds (retaining compatibility with the previous behavior) but is also used to determine when to keep response files.
e0ea1a0
to
4156c93
Compare
This is blocking #9367.
Currently,
cabal repl
has a--keep-temp-files
option, andcabal.project
has akeep-temp-files
option but it only affects Haddock builds.This patch adds
--keep-temp-files
toCommonSetupFlags
, making it available to all commands. The expanded--keep-temp-files
flag is used for thecabal repl
command and Haddock builds (retaining compatibility with the previous behavior). The flag will also be used for response files; see #9367.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR: