Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codebuild fleet import #39385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aleksandarknezevic
Copy link
Contributor

@aleksandarknezevic aleksandarknezevic commented Sep 18, 2024

Description

FIx CodeBuild fleet import by making sure that fleet ARN is set as ID

Relations

Closes #39362

References

Output from Acceptance Testing

make testacc TESTS=TestAccCodeBuildFleet_ PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildFleet_'  -timeout 360m
=== RUN   TestAccCodeBuildFleet_basic
=== PAUSE TestAccCodeBuildFleet_basic
=== RUN   TestAccCodeBuildFleet_disappears
=== PAUSE TestAccCodeBuildFleet_disappears
=== RUN   TestAccCodeBuildFleet_tags
=== PAUSE TestAccCodeBuildFleet_tags
=== RUN   TestAccCodeBuildFleet_baseCapacity
=== PAUSE TestAccCodeBuildFleet_baseCapacity
=== RUN   TestAccCodeBuildFleet_computeType
=== PAUSE TestAccCodeBuildFleet_computeType
=== RUN   TestAccCodeBuildFleet_environmentType
=== PAUSE TestAccCodeBuildFleet_environmentType
=== RUN   TestAccCodeBuildFleet_imageId
=== PAUSE TestAccCodeBuildFleet_imageId
=== RUN   TestAccCodeBuildFleet_scalingConfiguration
=== PAUSE TestAccCodeBuildFleet_scalingConfiguration
=== RUN   TestAccCodeBuildFleet_vpcConfig
=== PAUSE TestAccCodeBuildFleet_vpcConfig
=== CONT  TestAccCodeBuildFleet_basic
=== CONT  TestAccCodeBuildFleet_environmentType
=== CONT  TestAccCodeBuildFleet_vpcConfig
=== CONT  TestAccCodeBuildFleet_scalingConfiguration
=== CONT  TestAccCodeBuildFleet_imageId
=== CONT  TestAccCodeBuildFleet_baseCapacity
=== CONT  TestAccCodeBuildFleet_computeType
=== CONT  TestAccCodeBuildFleet_tags
=== CONT  TestAccCodeBuildFleet_disappears
--- PASS: TestAccCodeBuildFleet_basic (72.92s)
--- PASS: TestAccCodeBuildFleet_computeType (80.41s)
--- PASS: TestAccCodeBuildFleet_baseCapacity (80.55s)
--- PASS: TestAccCodeBuildFleet_imageId (81.91s)
--- PASS: TestAccCodeBuildFleet_disappears (83.48s)
--- PASS: TestAccCodeBuildFleet_environmentType (94.77s)
--- PASS: TestAccCodeBuildFleet_scalingConfiguration (107.11s)
--- PASS: TestAccCodeBuildFleet_vpcConfig (110.78s)
--- PASS: TestAccCodeBuildFleet_tags (121.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  128.459s

@aleksandarknezevic aleksandarknezevic requested a review from a team as a code owner September 18, 2024 23:41
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/codebuild Issues and PRs that pertain to the codebuild service. needs-triage Waiting for first response or review from a maintainer. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Waiting for first response or review from a maintainer. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error changing aws_codebuild_fleet resource after importing
1 participant