Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer port number #39160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

covracer
Copy link

@covracer covracer commented Sep 5, 2024

Description

This should allow the following in Python CDKTF:

LbListener(
    stack,
    'http',
    default_action=[
        LbListenerDefaultAction(
            redirect=LbListenerDefaultActionRedirect(
                port=443, protocol='HTTPS', status_code='HTTP_301'
            ),
            type='redirect',
        ),
    ],
    load_balancer=load_balancer.arn,
    port=80,
    protocol='HTTP',
)

Previously port='443' was required to avoid

TypeError: type of argument port must be one of (str, NoneType); got int instead

This should allow the following in Python CDKTF:
```python
LbListener(
    stack,
    'http',
    default_action=[
        LbListenerDefaultAction(
            type='redirect',
            redirect=LbListenerDefaultActionRedirect(
                port=443, protocol='HTTPS', status_code='HTTP_301'
            ),
        ),
    ],
    load_balancer=load_balancer.arn,
    port=80,
    protocol='HTTP',
```

Previously `port='443'` was required to avoid
```
TypeError: type of argument port must be one of (str, NoneType); got int instead
```
@covracer covracer requested a review from a team as a code owner September 5, 2024 11:54
Copy link

github-actions bot commented Sep 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. labels Sep 5, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @covracer 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants