Using helms chart-repo-actions demo to lint and test helm chart changes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Halder <[email protected]>
Signed-off-by: Matt Halder <[email protected]>
Nana-EC
requested changes
Oct 20, 2023
…irectory Signed-off-by: Matt Halder <[email protected]>
Signed-off-by: Matt Halder <[email protected]>
Made this change but did it to test on PRs only. I think that's a better setup, running the testing and linting when merge means the tests would only ever run after the code being tested is approved and merged. This order makes more sense imo |
Nana-EC
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for linting and testing the helm chart
Related issue(s):
Relates to #1
Notes for reviewer:
This setup is mostly from here