Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding further permissions to the manual-testing workflow as it was not running correctly. #956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Sep 20, 2024

Description:
There were issues with the workflow where acceptance-workflow was requesting further permissions and it would break:
Link to issue. This should resolve that issue.

Related issue(s):

Fixes #955

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…as not running correctly.

Signed-off-by: Vasil Boyadzhiev <[email protected]>
@san-est san-est added the github_actions Pull requests that update GitHub Actions code label Sep 20, 2024
@san-est san-est added this to the 0.10.0 milestone Sep 20, 2024
@san-est san-est self-assigned this Sep 20, 2024
@san-est san-est linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link

Test Results

 16 files  ± 0   80 suites  ±0   6m 51s ⏱️ -17s
246 tests  - 16  233 ✅  - 23  6 💤 ±0  7 ❌ +7 
271 runs  ± 0  257 ✅  -  7  7 💤 ±0  7 ❌ +7 

For more details on these failures, see this check.

Results for commit 932ccfa. ± Comparison against base commit 587ed1c.

This pull request removes 18 and adds 2 tests. Note that renamed tests count towards both.
should NOT be able to use approve ‑ ERC20Contract Test Suite should NOT be able to use approve
should NOT be able to use delegateApprove and allowance ‑ ERC20Contract Test Suite should NOT be able to use delegateApprove and allowance
should NOT be able to use delegateTransfer ‑ ERC20Contract Test Suite should NOT be able to use delegateTransfer
should NOT be able to use delegateTransferFrom ‑ ERC20Contract Test Suite should NOT be able to use delegateTransferFrom
should NOT be able to use transfer ‑ ERC20Contract Test Suite should NOT be able to use transfer
should be able to approve another account ‑ IERC20 Test Suite should be able to approve another account
should be able to execute transferFrom to another account ‑ IERC20 Test Suite should be able to execute transferFrom to another account
should be able to get token balance of any account ‑ ERC20Contract Test Suite should be able to get token balance of any account
should be able to get token balance of any account ‑ IERC20 Test Suite should be able to get token balance of any account
should be able to get token decimals ‑ ERC20Contract Test Suite should be able to get token decimals
…
"before all" hook for "should be able to get token name" ‑ ERC20Contract Test Suite "before all" hook for "should be able to get token name"
"before all" hook for "should be able to get token name" ‑ IERC20 Test Suite "before all" hook for "should be able to get token name"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue in workflows/manual-testing.yml permissions.
1 participant