Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new tests for HIP-1010 #911

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

konstantinabl
Copy link
Collaborator

@konstantinabl konstantinabl commented Aug 19, 2024

Description:

Testing new functionality regarding fees, namely updateFungibleTokenCustomFeesPublic and updateNonFungibleTokenCustomFeesPublic (HIP-1010), but ALSO testing if fees are correctly deducted from accounts, since there were no such test before. Thus, the tests in this PR are slightly bigger and more complex than expected

Related issue(s):

Fixes #876

@konstantinabl konstantinabl linked an issue Aug 19, 2024 that may be closed by this pull request
@konstantinabl konstantinabl added the enhancement New feature or request label Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

Test Results

 16 files  ± 0   82 suites  +2   11m 32s ⏱️ + 4m 35s
288 tests +43  275 ✅ +37  6 💤 ±0  7 ❌ +6 
299 runs  +28  285 ✅ +22  7 💤 ±0  7 ❌ +6 

For more details on these failures, see this check.

Results for commit b2326fc. ± Comparison against base commit bc3a549.

This pull request removes 4 and adds 47 tests. Note that renamed tests count towards both.
"before each" hook for "Should be able to mint a new token" ‑ @OZERC1155Token Test Suite "before each" hook for "Should be able to mint a new token"
should be able to make Non-Fungible Token transfer and sign it with hollow account ‑ HIP583 Test Suite Direct Ethereum Tx Positive Non-Fungible Token Test should be able to make Non-Fungible Token transfer and sign it with hollow account
should be able to make second Non-Fungible Token transfer ‑ HIP583 Test Suite Direct Ethereum Tx Positive Non-Fungible Token Test should be able to make second Non-Fungible Token transfer
should create hollow account and transfer Non-Fungible Token ‑ HIP583 Test Suite Direct Ethereum Tx Positive Non-Fungible Token Test should create hollow account and transfer Non-Fungible Token
"before all" hook for "should create hollow account and transfer Non-Fungible Token" ‑ HIP583 Test Suite Direct Ethereum Tx Positive Non-Fungible Token Test "before all" hook for "should create hollow account and transfer Non-Fungible Token"
Should NOT allow a non-operator to transfer tokens to another account ‑ @OZERC1155Token Test Suite Should NOT allow a non-operator to transfer tokens to another account
Should NOT burn insufficient amount of token ‑ @OZERC1155Token Test Suite Should NOT burn insufficient amount of token
Should NOT transfer the ownership to another account if the caller is not owner ‑ @OZERC1155Token Test Suite Should NOT transfer the ownership to another account if the caller is not owner
Should allow an operator to transfer a token to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer a token to another account
Should allow an operator to transfer tokens in batch to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer tokens in batch to another account
Should be able to mint a new token ‑ @OZERC1155Token Test Suite Should be able to mint a new token
Should be able to mint new tokens in batch ‑ @OZERC1155Token Test Suite Should be able to mint new tokens in batch
Should burn token in batch ‑ @OZERC1155Token Test Suite Should burn token in batch
Should burn token ‑ @OZERC1155Token Test Suite Should burn token
…

♻️ This comment has been updated with latest results.

@konstantinabl
Copy link
Collaborator Author

Blocked by hashgraph/hedera-mirror-node#9136
We need this change in the relay in order to be able to return predefined gas for smart contracts that are in services, but not yet in the mirror node

@konstantinabl
Copy link
Collaborator Author

This issue was resolved, however currently waiting for a new release of the local node that will use newest mirror node tag 0.113.1

@konstantinabl konstantinabl force-pushed the 876-hip-1010-solidity-reference-definition branch from f39602c to b2326fc Compare September 20, 2024 15:23
@konstantinabl konstantinabl marked this pull request as ready for review September 20, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Tasks In Progress
Development

Successfully merging this pull request may close these issues.

HIP-1010: Solidity reference definition
1 participant