Update jooq repository to improve reusability #9424
Conversation
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
…endpoint-to-rest-api
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
edwin-greene
changed the title
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9424 +/- ##
============================================
- Coverage 92.68% 92.54% -0.14%
- Complexity 6943 7067 +124
============================================
Files 896 915 +19
Lines 29553 29842 +289
Branches 3745 3780 +35
============================================
+ Hits 27390 27617 +227
- Misses 1399 1447 +48
- Partials 764 778 +14 ☔ View full report in Codecov by Sentry. |
|
|
||
| private final String parameterName; | ||
|
|
||
| private final EnumMap<RangeOperator, Integer> cardinality = new EnumMap<>(RangeOperator.class); | ||
|
|
||
| public Bound(List<EntityIdRangeParameter> params, boolean primarySortField, String parameterName) { | ||
| public Bound(RangeParameter<Long>[] params, boolean primarySortField, String parameterName, Field<Long> field) { |
There was a problem hiding this comment.
Bounds can now be NumberRangeParameter bounds (because of the serial number bound), instead of just EntityIdRangeParameter, so I updated this from a list to an array to accept the interface of both RangeParameter.
| var secondaryBound = tokenIds == null ? tertiaryBound : tokenIds; | ||
| var primaryBound = entityIds == null ? secondaryBound : entityIds; | ||
| return List.of(primaryBound, secondaryBound, tertiaryBound); | ||
| } |
There was a problem hiding this comment.
This class already contained the specifics concerning the ordering of the jooq Fields in AirdropRequestType, so it seemed to fit to place the specifics for the ordering of the bounds here. But we could place this in one of the other layers as well.
Description:
Updates the Bound class to include fields.
Simplifies the JooqRepository to only accept Bounds as parameters.
Updates the JooqRepository to support N-numbered conditions.
Related issue(s):
Fixes #9379
Notes for reviewer:
This should not be merged until the work for pagination for airdrop nfts is completed in #9378
Checklist