Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: entity ID in TOKENREJECT #1370

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Sep 20, 2024

Description:

Interpret Entity ID from TOKENREJECT as Account ID instead of Token ID

Before:
Screenshot 2024-09-20 at 09 25 54

After:
Screenshot 2024-09-20 at 09 40 29

Related issue(s):

Fixes #1369

@svienot svienot self-assigned this Sep 20, 2024
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.59% 23871 / 30763
🔵 Statements 77.59% 23871 / 30763
🔵 Functions 61.26% 952 / 1554
🔵 Branches 84.48% 4613 / 5460
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/EntityDescriptor.ts 95.78% 54.38% 100% 95.78% 43-44, 122-123
src/utils/TransactionTools.ts 80.31% 63.63% 80% 80.31% 30-32, 36-37, 39-40, 53-54, 68-69, 80-81, 92-93, 98-104, 106-125, 127-136, 138-139, 142, 144-153, 331-332, 344-345, 360-361, 425-427, 430-431
Generated in workflow #1293

Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@svienot svienot merged commit a56107e into main Sep 20, 2024
7 of 8 checks passed
@svienot svienot deleted the 1369-fix-entity-id-in-token-reject branch September 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity ID in TOKENREJECT transaction is interpreted as a Token ID
2 participants