Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simulator gRPC Client implementation and initial configuration #182

Merged
merged 8 commits into from
Sep 20, 2024
Merged

feat: Simulator gRPC Client implementation and initial configuration #182

merged 8 commits into from
Sep 20, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Sep 16, 2024 •
edited
Loading

Description:

  • Added BlockAsDirBlockStreamManager Implementation, to be able to test recordings from the BlockNode itself.
  • Added Netty Shaded dependencies using the gradle files.
  • improved smoke-test to only run the :server project
  • Created a gRPC Client for PublishBlockStream to the BN.
  • Added Example blocks for the different test cases and implementations.
  • Added Unit Tests for everything new.

Related issue(s):

Fixes #159

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 self-assigned this Sep 17, 2024
@AlfredoG87 AlfredoG87 added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Sep 17, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Sep 17, 2024
@AlfredoG87 AlfredoG87 marked this pull request as ready for review September 17, 2024 01:28
@AlfredoG87 AlfredoG87 requested review from a team as code owners September 17, 2024 01:28
mattp-swirldslabs
mattp-swirldslabs reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work...I left a few comments and questions

.github/workflows/smoke-test.yaml Outdated Show resolved Hide resolved
gradle/modules.properties Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/BlockStreamSimulatorApp.java Outdated Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/BlockStreamSimulatorApp.java Outdated Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/generator/GeneratorInjectionModule.java Show resolved Hide resolved
simulator/src/main/resources/BlockAsDirException/1/1.blk Outdated Show resolved Hide resolved
simulator/src/main/resources/app.properties Show resolved Hide resolved
simulator/src/test/java/com/hedera/block/simulator/config/TestConfigBuilder.java Outdated Show resolved Hide resolved
simulator/src/test/java/com/hedera/block/simulator/config/TestConfigBuilder.java Show resolved Hide resolved
georgi-l95
georgi-l95 reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, one nit. After resolving Matt comments I think will be okay for merging 👍

simulator/src/main/java/com/hedera/block/simulator/generator/BlockAsDirBlockStreamManager.java Outdated Show resolved Hide resolved
@georgi-l95 georgi-l95 mentioned this pull request Sep 18, 2024
Merged
2 tasks
@mattp-swirldslabs mattp-swirldslabs mentioned this pull request Sep 18, 2024
Merged
2 tasks
@AlfredoG87 AlfredoG87 changed the base branch from 00168-ref-async to main September 18, 2024 21:14
@AlfredoG87
- gRPC client implementation using Netty.shaded
09cb8a0 
- BlockAsDir Implementation for BlockStreamManager
- Added Example files/blocks for streaming and testing (UT)
- Unit Tests for all above
- Changes to Smoke test to fix it.
- Updated Helidon from 4.1.0 to 4.1.1

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
Addressed PR Review comments
08c097e 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
removed unused leftover import
d6a1969 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
improving javadocs
34060ac 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
Fixing blockAsDirData
f4ce0c4 
Signed-off-by: Alfredo Gutierrez <[email protected]>
mattp-swirldslabs
mattp-swirldslabs previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jsync-swirlds
jsync-swirlds reviewed Sep 19, 2024
View reviewed changes
settings.gradle.kts Outdated Show resolved Hide resolved
rbarkerSL
rbarkerSL previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review covers codecov.yml; looks good to me.

mattp-swirldslabs
mattp-swirldslabs approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlfredoG87 AlfredoG87 merged commit f78143f into main Sep 20, 2024
12 checks passed
@AlfredoG87 AlfredoG87 deleted the simulator-grpc-client2 branch September 20, 2024 15:10
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (f3e1b62) to head (7c0b5a7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #182      +/-   ##
============================================
+ Coverage     99.73%   99.77%   +0.03%     
- Complexity      208      238      +30     
============================================
  Files            44       48       +4     
  Lines           763      872     +109     
  Branches         48       58      +10     
============================================
+ Hits            761      870     +109     
  Misses            2        2
Files with missing lines Coverage Δ
...edera/block/simulator/BlockStreamSimulatorApp.java 100.00% <100.00%> (ø)
...block/simulator/config/data/BlockStreamConfig.java 100.00% <ø> (ø)
...ulator/generator/BlockAsDirBlockStreamManager.java 100.00% <100.00%> (ø)
...lator/generator/BlockAsFileBlockStreamManager.java 100.00% <100.00%> (ø)
.../simulator/generator/GeneratorInjectionModule.java 100.00% <100.00%> (ø)
...ck/simulator/grpc/PublishStreamGrpcClientImpl.java 100.00% <100.00%> (ø)
...ra/block/simulator/grpc/PublishStreamObserver.java 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs approved these changes

@rbarkerSL rbarkerSL rbarkerSL approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95

@jsync-swirlds jsync-swirlds Awaiting requested review from jsync-swirlds

Assignees

@AlfredoG87 AlfredoG87

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

gRPC client for publishBlockStream
5 participants
@AlfredoG87 @georgi-l95 @mattp-swirldslabs @jsync-swirlds @rbarkerSL