You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a Block Node administrator
I want production configuration by default
so that I can minimize dealing with app.properties changes
Currently, smoke_test.yaml runs the smoke tests using gradle run to verify with smoke_test.sh
It's more difficult to override the default configuration because this does not use a test app.properties file when it starts the Block Node
Record files like: MediatorConfig.java and NotifierConfig.java currently must be defaulted to non-production values (e.g. 1024 for the ring buffer rather than a more realistic prod value like 67108864) so that the smoke test does not throw an OutOfMemory error.
As a result, the production app.properties file must contain the prod values instead to override the defaults when running in a container.
Perhaps we should change the CI tests to:
Run the smoke tests via docker rather than gradle. Gradle is strictly used for build and development.
Set the defaults in the config record files like MediatorConfig.java and NotifierConfig.java to the production defaults
Remove the override values in app.properties to minimize the configuration burden.
Leverage the test app.properties inside the container noted in Create LICENSE #1 to override the production defaults with test config.
The text was updated successfully, but these errors were encountered:
As a Block Node administrator
I want production configuration by default
so that I can minimize dealing with app.properties changes
smoke_test.yaml
runs the smoke tests usinggradle run
to verify withsmoke_test.sh
MediatorConfig.java
andNotifierConfig.java
currently must be defaulted to non-production values (e.g. 1024 for the ring buffer rather than a more realistic prod value like 67108864) so that the smoke test does not throw an OutOfMemory error.app.properties
file must contain the prod values instead to override the defaults when running in a container.Perhaps we should change the CI tests to:
MediatorConfig.java
andNotifierConfig.java
to the production defaultsapp.properties
to minimize the configuration burden.app.properties
inside the container noted in Create LICENSE #1 to override the production defaults with test config.The text was updated successfully, but these errors were encountered: