Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: header-links icons should be unique #777

Merged
merged 6 commits into from
Jun 14, 2024
Merged

test: header-links icons should be unique #777

merged 6 commits into from
Jun 14, 2024

Conversation

dorinzrihen
Copy link
Collaborator

Description

add a test with Playwright that make sure there is no duplicate SVG

screenshots

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9379103589/open-bus/8f8f134306a2fd631547d82668b1185c1d12336e/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9379103589/open-bus/8f8f134306a2fd631547d82668b1185c1d12336e/storybook/index.html

@NoamGaash NoamGaash changed the title feat: Test | header-links icons should be unique test | header-links icons should be unique Jun 2, 2024
@NoamGaash NoamGaash changed the title test | header-links icons should be unique test: header-links icons should be unique Jun 2, 2024
NoamGaash
NoamGaash approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's exactly what we needed!

@NoamGaash
Copy link
Member

The fix is merged, I'll update the branch

@NoamGaash
Copy link
Member

@dorinzrihen feel free to merge

@NoamGaash NoamGaash merged commit 32fbd70 into main Jun 14, 2024
18 of 19 checks passed
@NoamGaash NoamGaash deleted the feat/test-header-link-icons-should-be-unique branch June 14, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorinzrihen @NoamGaash