Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement homepage design according to figma #762

Merged
merged 7 commits into from
May 23, 2024

Conversation

itsoriki
Copy link
Collaborator

@itsoriki itsoriki commented May 21, 2024

Resolves #421

Description

Implemented homepage design according to Figma

Note: the footer is 100% of the whole screen (and therefore looks a bit too right right) because I couldn't find another way (oh, and I've tried to :))

screenshots

image

@itsoriki itsoriki marked this pull request as ready for review May 21, 2024 19:37
@itsoriki itsoriki requested a review from NoamGaash as a code owner May 21, 2024 19:37
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you 👏
But how do I get to this page?
Don't you want to make it the default route?

src/locale/en.json Outdated Show resolved Hide resolved
@itsoriki itsoriki requested a review from NoamGaash May 22, 2024 08:37
@NoamGaash
Copy link
Member

You can add:

.ant-layout {
    position: relative;
}
.container footer {
    position:absolute;
}
main:has(footer) {
    padding-bottom: 40px;
}

to fix footer centering

@itsoriki itsoriki enabled auto-merge (squash) May 23, 2024 04:54
@itsoriki itsoriki disabled auto-merge May 23, 2024 05:19
@itsoriki itsoriki enabled auto-merge (squash) May 23, 2024 06:05
@itsoriki itsoriki merged commit b5fa6c8 into main May 23, 2024
16 checks passed
@itsoriki itsoriki deleted the feat/421-implement-homepage-design-according-to-figma branch May 23, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement homepage design according to figma
2 participants