style(line-profile): table formatting for line metadata #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
changed the title
Tamir198
changed the title
Tamir198
changed the title
NoamGaash
approved these changes
Mar 9, 2024
src/pages/ProfileLineDetails.tsx
Outdated
| } | ||
|
|
||
| & .line-details { | ||
| height: 2rem; |
There was a problem hiding this comment.
That could be a problem when the lines are lengthy (especially on mobile devices).using line-height and padding would be better
There was a problem hiding this comment.
Updated the code and also checked on mobile (there the text is too big and the line will collapse and just take more space).
So now this is also fully mobile responsive.
There was a problem hiding this comment.
Perfect!
Thanks
(Your PR is approved, you can merge it using the merge button)
NoamGaash
changed the title
NoamGaash
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continue of #543
I changed the section where we display data on the line to look something like the table bellow regarding colors just to be consist.