Skip to content

Commit

Permalink
Fix build_callbacks close #1589
Browse files Browse the repository at this point in the history
  • Loading branch information
hankcs committed Dec 12, 2020
1 parent 5206714 commit 4ea9595
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion hanlp/common/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def fit(self, trn_data, dev_data, save_dir, batch_size, epochs, run_eagerly=Fals
self.save_meta(save_dir)
trn_data = self.build_train_dataset(trn_data, batch_size, num_examples)
dev_data = self.build_valid_dataset(dev_data, batch_size)
callbacks = self.build_callbacks(save_dir, logger, **self.config)
callbacks = self.build_callbacks(save_dir, **merge_dict(self.config, overwrite=True, logger=logger))
# need to know #batches, otherwise progbar crashes
dev_steps = math.ceil(size_of_dataset(dev_data) / batch_size)
checkpoint = get_callback_by_class(callbacks, tf.keras.callbacks.ModelCheckpoint)
Expand Down
6 changes: 4 additions & 2 deletions hanlp/components/parsers/biaffine_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from hanlp.layers.embeddings import build_embedding
from hanlp.metrics.parsing.labeled_f1 import LabeledF1
from hanlp.metrics.parsing.labeled_score import LabeledScore
from hanlp.utils.util import merge_locals_kwargs
from hanlp.utils.util import merge_locals_kwargs, merge_dict


class BiaffineDependencyParser(KerasComponent):
Expand Down Expand Up @@ -219,7 +219,9 @@ def build_train_dataset(self, trn_data, batch_size, num_examples):

# noinspection PyMethodOverriding
def build_callbacks(self, save_dir, logger, metrics, **kwargs):
callbacks = super().build_callbacks(save_dir, logger, metrics=metrics, **kwargs)
callbacks = super().build_callbacks(save_dir,
**merge_dict(self.config, overwrite=True, logger=logger, metrics=metrics,
**kwargs))
if isinstance(metrics, tuple):
metrics = list(metrics)
callbacks.append(self.build_progbar(metrics))
Expand Down
2 changes: 1 addition & 1 deletion hanlp/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Author: hankcs
# Date: 2019-12-28 19:26

__version__ = '2.0.0-alpha.67'
__version__ = '2.0.0-alpha.68'

0 comments on commit 4ea9595

Please sign in to comment.