Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Halo version variable to theme model #6677

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 19, 2024

What type of PR is this?

/kind feature
/milestone 2.20.x
/area theme

What this PR does / why we need it:

主题支持通过 ${site.version} 得到 Halo 版本号

Which issue(s) this PR fixes:

Fixes #6676

Does this PR introduce a user-facing change?

主题支持通过 `${site.version}` 得到 Halo 版本号

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 19, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 19, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/theme Issues or PRs related to the Theme Provider label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.09%. Comparing base (6cd8dc8) to head (1a5251f).
Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
...a/run/halo/app/theme/finders/vo/SiteSettingVo.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6677      +/-   ##
============================================
- Coverage     58.18%   58.09%   -0.09%     
- Complexity     3774     3937     +163     
============================================
  Files           651      675      +24     
  Lines         22125    23116     +991     
  Branches       1538     1578      +40     
============================================
+ Hits          12873    13430     +557     
- Misses         8641     9065     +424     
- Partials        611      621      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
Copy link

f2c-ci-robot bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@JohnNiang JohnNiang added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 19, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit dcadd38 into halo-dev:main Sep 19, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/theme Issues or PRs related to the Theme Provider kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望为主题提供 Halo 版本的变量
3 participants