Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make comment and reply list item operations extendable #393

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

chengzhongxue
Copy link
Contributor

@chengzhongxue chengzhongxue commented Aug 5, 2024

None

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 1:53pm

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 5, 2024 15:46
@ruibaby ruibaby changed the title make comment and reply list item operations extendable docs: make comment and reply list item operations extendable Aug 9, 2024
@ruibaby
Copy link
Member

ruibaby commented Aug 9, 2024

应该是修改 docs 目录,这个改动会在 2.19 发布,不是 2.18.

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 9, 2024
@chengzhongxue
Copy link
Contributor Author

我改改,开始没注意

Signed-off-by: Ryan Wang <[email protected]>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
Copy link

f2c-ci-robot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
Signed-off-by: Ryan Wang <[email protected]>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 4a53db8 into halo-dev:main Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants