Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the instructions for the initial administrator in the deployment document #244

Merged
merged 1 commit into from
Sep 1, 2023
Merged

docs: update the instructions for the initial administrator in the deployment document #244

merged 1 commit into from
Sep 1, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 16, 2023 •
edited
Loading

更新部署文档，移除通过参数的形式设置初始管理员。

/kind documentation

Fixes #241

None

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 16, 2023

@ruibaby: The label(s) kind/documentaion cannot be applied, because the repository doesn't have them.

In response to this:

更新部署文档，移除通过参数的形式设置初始管理员。

/kind documentaion

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 16, 2023
@vercel
Copy link

vercel bot commented Aug 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 2:36pm

@ruibaby ruibaby added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 16, 2023
@ruibaby
Update
74e4cfb 
Signed-off-by: Ryan Wang <[email protected]>
@ruibaby ruibaby force-pushed the docs/update-deploy-documentation branch from 6e1e3b0 to 74e4cfb Compare August 31, 2023 14:32
@ruibaby ruibaby changed the title WIP: docs: update the instructions for the initial administrator in the deployment document docs: update the instructions for the initial administrator in the deployment document Sep 1, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2023
JohnNiang
JohnNiang approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@ruibaby ruibaby merged commit 32163df into halo-dev:main Sep 1, 2023
4 of 5 checks passed
@ruibaby ruibaby deleted the docs/update-deploy-documentation branch September 1, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

修改部署文档，从 2.9 开始，初始化管理员将在初始化页面进行。
2 participants
@ruibaby @JohnNiang