-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deep live cam #596
base: main
Are you sure you want to change the base?
deep live cam #596
Conversation
Reviewer's Guide by SourceryThis pull request adds a new GitHub Actions workflow file for Python package testing and linting. The workflow is set up to run on push and pull request events for the main branch, using multiple Python versions. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hoangngoc5275 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The pull request title 'deep live cam' does not accurately reflect the content of the changes, which is adding a GitHub Actions workflow for Python package testing. Please update the title to be more descriptive of the actual changes.
- Consider upgrading actions/setup-python from v3 to v4 to ensure you're using the latest features and bug fixes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Fixed the Face mapper issue in Live Cam - New UI PR
added KRSHH
Fix formatting, structure etc.
Thanks to all the contributors
Update README.md
* 'main' of https://github.com/hoangngoc5275/Deepface: Create python-package.yml
Summary by Sourcery
Introduce a CI workflow using GitHub Actions to automate testing and linting for Python packages across multiple Python versions.
CI: