Fix hotkey selector panic #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows global hotkeys to be set to "not set" by setting to any incompatible value, for example Esc.
|
Thanks for your PR! Personally, I aim to push performance to the limit. I suggest changing Please fix the CI, and I'll merge it into the dev branch. After that, I'll make some improvements later. |
|
I'll change to |
AurevoirXavier
added
T1-Dev
Replace key_to_string()->String with key_to_str()->&str.
|
Sorry, with those orange workflows I am not sure if I did everything I needed to do or not. |
Merged
AurevoirXavier
added a commit
that referenced
this pull request
Jul 21, 2024
* Fix hotkey selector panic (#110) * Implement to_string() for keyboard::Keys and key * Allow unsetting global hotkeys Allows global hotkeys to be set to "not set" by setting to any incompatible value, for example Esc. * Improve keyboard.rs Replace key_to_string()->String with key_to_str()->&str. * Refactor hotkey::Manager * Allow empty hotkey --------- Co-authored-by: Barafu Albino Cheetah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes application panic when trying to set a global hotkey to an unsupported hotkey. Instead of paic, saves hotkey as "Not set", which also allows disabling hotkeys when not needed.