Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow nav_item to be opened in a new tab/window #1932 #2175

Merged
merged 6 commits into from
Oct 25, 2023
Merged

feat: Allow nav_item to be opened in a new tab/window #1932 #2175

merged 6 commits into from
Oct 25, 2023

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Oct 25, 2023 •
edited
Loading

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included
Screen.Recording.2023-10-25.at.13.05.19.mov

Closes #1932

@marek-mihok marek-mihok marked this pull request as ready for review October 25, 2023 20:09
mturoci
mturoci previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok! Just one minor change required.

ui/src/nav.tsx Outdated Show resolved Hide resolved
@mturoci mturoci merged commit af8b8b3 into main Oct 25, 2023
2 checks passed
@mturoci mturoci deleted the feat/issue-1932 branch October 25, 2023 23:57
marek-mihok added a commit that referenced this pull request Jan 15, 2024
@marek-mihok
feat: Allow nav_item to be opened in a new tab/window #1932 (#2175)
5813402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marek-mihok @mturoci