chore: Use maximum available space in ui.inline instead of hardcoded constant. #1974

[mturoci]

@marek-mihok - can you make a code review and a thorough QA to check if everything works as expected?

This is a rewrite of #1988 for #1974.

The reason some components shrunk drastically was wrong use of default align='center for case when direction='column'. This PR sets the following defaults:

• All components should try to occupy all the available space unless explicitly specified otherwise. This rule is in sync with regular form_card.items.
• The above default does not apply for cases when explicit alignment for main axis (justify) is chosen. In such case, the default width should correspond to the component's content, be it a label or anything else.

[marek-mihok]

Only one fix is needed and it's good to go, @mturoci !

[marek-mihok]

@mturoci, my QA efforts has continued also after the review and brought the new finding that two of our examples using ui.inline need adjustment to new changes:

• background_progress.py

• form_visibility.py

Our Tour and Wave University apps are intact.
I'll further continue with my QA and let you know if something pops up.

[mturoci]

Perfect. Those are expected and simple to fix. Good job nonetheless. Will fix in a sec.

[marek-mihok]

@mturoci, I hope this is the last one - if the user sets a fixed width for the element, it should not shrink to fit the available space (in 0:04 is the correct behavior, in 0:14 it is not):

Screen.Recording.2023-10-06.at.11.22.40.mov

[marek-mihok]

@mturoci, the similar problem as previous one, but with fixed height of the element when inline direction is column. When height of the ui.inline is lower than its content, the content does not shrink and there is no scrollbar either, it simply visibly overflows:

The example from the screenshot is this one with visualization part modified:

        ui.inline(direction='column', height='400px', items=[
            ui.visualization(
                height='500px',
                plot=ui.plot([ui.mark(type='interval', x='=product', y='=price', y_min=0)]),
                data=data(fields='product price', rows=[(c, x) for c, x, _ in [f.next() for _ in range(n)]], pack=True),
            ),
            ui.vega_visualization(
                height='500px',
                specification=spec,
                data=data(fields=["a", "b"], rows=[
                    ["A", rnd()], ["B", rnd()], ["C", rnd()],
                    ["D", rnd()], ["E", rnd()], ["F", rnd()],
                    ["G", rnd()], ["H", rnd()], ["I", rnd()]
                ], pack=True),
            ),
        ]),

[mturoci]

The code above seems incorrect as it sets the height of the container ui.inline=(height='400px') and then wants to put there 2 500px plots, which naturally results in an overflow. Simply removing the container height should be enough.

[marek-mihok]

Simply removing the container height should be enough.

In that case it's all from my side. I've also checked if everything works the same way across all 3 browsers. If you don't have anything else for me to test, I'll finish my QA.

[mturoci]

Thanks @marek-mihok!