Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add steps for uploading to ppa #17

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Aug 22, 2024

No description provided.

README.md Outdated
```
4. Upload
```bash
rake ubuntu UBUNTU_TARGETS=noble,24.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こうじゃない?

Suggested change
rake ubuntu UBUNTU_TARGETS=noble,24.04
rake package:ubuntu UBUNTU_TARGETS=noble,24.04

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1a8eaf5 を入れたから普通はUBUNTU_TARGETS=noble,24.04はいらなくなる。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リポジトリのルートでの実行だと package:ubuntu ですね。
一個前のダウンロードするところで cd packages したので、packages/ 内で実行している想定でした。

あいまいなので実行ディレクトリを明記します。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ルートでrake package:ubuntu一発でできて欲しい。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おけまるです。
タスクを改善して、それに合わせて手順も更新します。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いやぁ、改善しなくても現状でそうなっている気がするんだよねぇ。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ぉぉ、まじすか。
参考にした手順が悪かったかな。ちょっと手元で確認して内容を更新します。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一回 cd packages をする手順で作業していたのが悪かったです。ルートで rake package:ubuntu でいけました。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いやぁ、cd packagesしていても動くはずだったんだけどねぇ。
rake package:ubuntuってcd packages && rake ubuntuしているだけなので。

README.md Outdated
Comment on lines 320 to 325
3. Download source code
```bash
cd packages
rake source:download
cp ./source/tmp/downloads/*/groonga-nginx-*.tar.gz ..
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

うーん、これ、自動化されていると思うんだよねぇ。手元でやると勝手にダウンロードしてシンボリックリンクを張るよ。

README.md Outdated
* The environment variables used in this repository are `GROONGA_REPOSITORY`, `LAUNCHPAD_UPLOADER_PGP_KEY` and `APACHE_ARROW_REPOSITORY`
2. Install `nginx-dev`
* Install `nginx-dev` as it is also required
* Note: The working machine must be 24.04 or higher for Ubuntu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Note: The working machine must be 24.04 or higher for Ubuntu
* Note: The working machine must be Ubuntu 24.04+ or for Debian bookworm+

@abetomo
Copy link
Contributor Author

abetomo commented Aug 23, 2024

手順を見直すのでDraftにする。

@abetomo abetomo marked this pull request as draft August 23, 2024 03:08
@abetomo abetomo marked this pull request as ready for review August 23, 2024 03:41
@kou kou merged commit b5ab01a into groonga:main Aug 23, 2024
3 of 4 checks passed
@abetomo abetomo deleted the docs-add-release-steps branch August 23, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants