Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump consul-template version to 0.24.1 #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poblahblahblah
Copy link

Hi Grig,

Long time no speak :)

This change bumps the version up to the latest, 0.24.1

Copy link
Owner

@griggheo griggheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge but have you tested that everything works well with the updated version of consul-template?

@poblahblahblah
Copy link
Author

The only thing that pops up is a deprecation warning because the config format has changed since 0.15.x

2020/02/05 17:21:45 [WARN] consul now accepts a stanza instead of a string. Update your configuration files and change consul = "" to consul { } instead.
2020/02/05 17:21:45.175351 [INFO] consul-template v0.24.1 (c54d0abc)
2020/02/05 17:21:45.175365 [INFO] (runner) creating new runner (dry: false, once: false)
2020/02/05 17:21:45.175812 [INFO] (runner) creating watcher
2020/02/05 17:21:45.175914 [INFO] (runner) starting

We do have a few unrelated tweaks in our local fork of the repo, but nothing that would impact the config. I can MR those as well, if interested.

Copy link
Owner

@griggheo griggheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants