apollo_fpga.gateware: do not trigger reconfiguration using flash --fast
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossmann
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Unfortunately this leaves the flash bridge running on the shared USB port. To be consistent with the state diagram, we should hand the port off to Apollo (if the platform has a shared USB port) and then use Apollo to force the FPGA offline. Without doing that, I think the user is stuck in flash bridge mode; they'd have to push a physical button or write some Python to talk to the advertiser to regain control of the Cynthion.
Return control to Apollo instead to match `flash` behavior.
mndza
force-pushed
the
flash-bridge-no-reconfigure
branch
from
591d144
to
b871346
Compare
|
Sorry! I updated the PR to match that behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79.