Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware: select string descriptors at run time #82

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

mossmann
Copy link
Member

Cynthion now identifies itself on USB with the trademarks "Cynthion" and "Great Scott Gadgets" only if it is detected to have been manufactured by Great Scott Gadgets at run time. This also cleans up string descriptor handling for Cynthion and other SAMD11/SAMD21 platforms. It does not update other platforms which I think require discussion before changing.

@mossmann mossmann requested a review from mndza June 23, 2024 14:25
Copy link
Contributor

@mndza mndza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mossmann mossmann merged commit 2523d9a into greatscottgadgets:main Jun 24, 2024
11 checks passed
@mossmann mossmann deleted the string-descriptors branch June 24, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants