Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware: implement new LED scheme #50

Merged
merged 1 commit into from
May 16, 2024

Conversation

mndza
Copy link
Contributor

@mndza mndza commented May 2, 2024

Fixes #39.

@mossmann
Copy link
Member

mossmann commented May 6, 2024

@mndza You asked about the name led_event() and, after some thought, I think that using "status" or "indicator" might be better than "LED" for naming the parts of this that aren't directly tied to LEDs. In the future we might use other methods such as a USB vendor request to retrieve status information and/or indicate that status to the user, particularly for platforms that have fewer LEDs.

@mndza mndza force-pushed the new-led-scheme branch 6 times, most recently from 13c2fe9 to 794fec9 Compare May 15, 2024 07:50
@mndza mndza requested a review from mossmann May 15, 2024 07:52
@mndza mndza marked this pull request as ready for review May 15, 2024 07:52
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mossmann mossmann merged commit 87b5f53 into greatscottgadgets:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LED usage
2 participants