Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Tagged type #733

Closed
wants to merge 45 commits into from
Closed

[RFC] Tagged type #733

wants to merge 45 commits into from

Commits on Jun 12, 2020

  1. First pass

    @benjie
    benjie committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    3d43179 View commit details
    Browse the repository at this point in the history

  2. More edits

    @benjie
    benjie committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    d411b60 View commit details
    Browse the repository at this point in the history

  3. Input coercion

    @benjie
    benjie committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    16de657 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Change tagged "fields" to "members"

    @benjie
    benjie committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    a73d1cc View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Merge branch 'master' into tagged-type

    @benjie
    benjie committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    ceb81d5 View commit details
    Browse the repository at this point in the history

  2. Sync type system

    @benjie
    benjie committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    e65126d View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Factor in review feedback from @spawnia

    @benjie
    benjie committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    a4c4578 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Merge branch 'master' into tagged-type

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c31ddc4 View commit details
    Browse the repository at this point in the history

  2. Move TaggedMemberDefinition

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    55feb1c View commit details
    Browse the repository at this point in the history

  3. Add TAGGED_MEMBER_DEFINITION directive location

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    f786f1c View commit details
    Browse the repository at this point in the history

  4. Reorder so tagged types comes after interfaces/unions

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    5906cd0 View commit details
    Browse the repository at this point in the history

  5. Edit out comma that snuck in

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    bd88e51 View commit details
    Browse the repository at this point in the history

  6. Add word 'concrete'

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    514bb72 View commit details
    Browse the repository at this point in the history

  7. Define member field

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    4768d8d View commit details
    Browse the repository at this point in the history

  8. Add Lee's note

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    95ccf95 View commit details
    Browse the repository at this point in the history

  9. Lee's rewording

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    88f983b View commit details
    Browse the repository at this point in the history

  10. Add mutually exclusive tagged type example with distinct types

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    a6486ce View commit details
    Browse the repository at this point in the history

  11. Make it clear Tagged type fields can be of any type.

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    cf8d7a6 View commit details
    Browse the repository at this point in the history

  12. s/objects/results

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    a09b30a View commit details
    Browse the repository at this point in the history

  13. :

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c81ebb1 View commit details
    Browse the repository at this point in the history

  14. Checking for one key is easier than validating the given keys (maybe)

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    5dcb81b View commit details
    Browse the repository at this point in the history

  15. nit

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    71ca892 View commit details
    Browse the repository at this point in the history

  16. Allow @deprecated on TAGGED_MEMBER_DEFINITION

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    ce213bb View commit details
    Browse the repository at this point in the history

  17. Reword note on tagged member deprecation

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    7ac7532 View commit details
    Browse the repository at this point in the history

  18. Add note that added members must not make the tagged type invalid

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    0ae9ba8 View commit details
    Browse the repository at this point in the history

  19. Fix case

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    361a235 View commit details
    Browse the repository at this point in the history

  20. Remove duplicate

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    a1705b5 View commit details
    Browse the repository at this point in the history

  21. Reword to follow Lee's example

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    8807c1c View commit details
    Browse the repository at this point in the history

  22. Reposition TAGGED to always be between Union and Enum.

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    61b7b8f View commit details
    Browse the repository at this point in the history

  23. Terran -> Earthling

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    285673a View commit details
    Browse the repository at this point in the history

  24. Make header consistent

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    d9820c4 View commit details
    Browse the repository at this point in the history

  25. __Type represents all named types in the system

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    f91d8ba View commit details
    Browse the repository at this point in the history

  26. Apply Lee's suggestion

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    82151ba View commit details
    Browse the repository at this point in the history

  27. Combine

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    02a2a93 View commit details
    Browse the repository at this point in the history

  28. Use 'field' rather than 'key'

    @benjie
    benjie committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    5bdcc30 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. GetTaggedMember[Field]Name

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    88e506a View commit details
    Browse the repository at this point in the history

  2. __[Tagged]Member[Field]

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    fee5ca3 View commit details
    Browse the repository at this point in the history

  3. TAGGED_MEMBER_[FIELD_]DEFINITION

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    0f5d7cc View commit details
    Browse the repository at this point in the history

  4. TaggedMember[Field]Definition/TaggedMember[Field]sDefinition

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    94a67b7 View commit details
    Browse the repository at this point in the history

  5. taggedMember[Field]Name

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    f66e237 View commit details
    Browse the repository at this point in the history

  6. Fix definition ordering

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    e308258 View commit details
    Browse the repository at this point in the history

  7. Members -> member fields

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    6fa34c2 View commit details
    Browse the repository at this point in the history

  8. Grammar

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    4bf67b4 View commit details
    Browse the repository at this point in the history

  9. Fix incorrect capital

    @benjie
    benjie committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    5afea0b View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Separate input and output tagged types

    @benjie
    benjie committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    ced63be View commit details
    Browse the repository at this point in the history