Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config comment of using both queryurl and deployment_id #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: config comment of using both queryurl and deployment_id #341

wants to merge 1 commit into from
+1 −1

Conversation

carlosvdr
Copy link
Contributor

fixes #257

@carlosvdr carlosvdr self-assigned this Oct 2, 2024
@coveralls
Copy link

coveralls commented Oct 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11169604737

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.757%
Totals Coverage Status
Change from base Build 11133358093: 0.0%
Covered Lines: 4364
Relevant Lines: 6256
💛 - Coveralls

gusinacio
gusinacio requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a docs update, please reword your commit.

config/maximal-config-example.toml Outdated
Comment on lines 62 to 63
# NOTE: It is heavily recomended to use both `query_url` and `deployment_id`,
# however it can work with either one.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query_url is mandatory so you can not use either one. It must have query_url and it's also recommended to set a deployment_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@carlosvdr carlosvdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config: wrong comment about subgraph config
3 participants
@carlosvdr @coveralls @gusinacio