refactor: Add an timeout object to timer return type
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilacog
changed the title
intervalID to timer return typetimeout object to timer return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
timerfunction to return a tuple with thetimeoutobject returned by the call tosetIntervalalongside theEventual<number>timer.Users could then cancel the timer with
cancelInterval(timeout)or make it unblock the main Node process withtimeout.unref().This pull request aims to fix an issue where the Indexer Agent tests keep the NodeJS process alive after completing the tests and tearing down resources (like the DB). This causes the process to exit with a non-zero code since the program execution tied to such timers relies on those resources.