Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sorting logic in scene/dataset_readers.py for readColmapSceneInfo #735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bro-sin
Copy link

@bro-sin bro-sin commented Apr 2, 2024

Hello, I found an issue in scene/dataset_readers.py. Specifically, there was a problem with the sorting logic when images were named using numbers, leading to incorrect ordering. The root cause was the original sorting based on the image_name attribute, which resulted in unexpected sorting due to the way Python sorts characters. For example, images named as 1.png, 11.png, 2.png, and 22.png were being sorted as 1.png, 11.png, 2.png, and 22.png, respectively.
This PR fixes the issue where images were not sorted correctly when their names contained numbers. The previous sorting based on image_name resulted in incorrect order due to the way characters are sorted in Python. By changing the sorting key to uid, the images are now sorted accurately and consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants