Reapply "catch exception in GrailsApplicationBuilder (#425)" #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a793484.
matrei
approved these changes
Sep 26, 2024
| try { | ||
| objectMapper = ClassUtils.forName('com.fasterxml.jackson.databind.ObjectMapper', context.getClassLoader()) | ||
| } catch (ignored) { | ||
| } | ||
| if (objectMapper) { | ||
| beanExcludes.add(objectMapper) | ||
| } |
There was a problem hiding this comment.
Could even be simplified to:
try {
Class<?> objectMapper = ClassUtils.forName('com.fasterxml.jackson.databind.ObjectMapper', context.classLoader)
beanExcludes.add(objectMapper)
} catch (ignored) {
// ObjectMapper not found on classpath
}There was a problem hiding this comment.
Thanks, updated.
|
@jamesfredley I was looking at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a793484.
We will need a catch this exception given that Spring's ClassUtils.forName('com.fasterxml.jackson.databind.ObjectMapper', context.getClassLoader()) can throw an exception and https://docs.micronaut.io/4.6.5/api/io/micronaut/core/reflect/ClassUtils.html#forName(java.lang.String,java.lang.ClassLoader) did not.