Skip to content

Commit

Permalink
Remove @PendingFeature and @ignore for tests that are passing after #435
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesfredley committed Sep 29, 2024
1 parent 5af68c1 commit 0eced77
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 21 deletions.
5 changes: 0 additions & 5 deletions examples/demo33/src/test/groovy/demo/AutowiredTestSpec.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@ package demo

// tag::test_declaration[]
import grails.testing.spring.AutowiredTest
import spock.lang.Ignore
import spock.lang.PendingFeature
import spock.lang.Specification

@Ignore('helperService is null')
class AutowiredTestSpec extends Specification implements AutowiredTest {

Closure doWithSpring() {{ ->
Expand All @@ -19,13 +16,11 @@ class AutowiredTestSpec extends Specification implements AutowiredTest {
assert helperService != null
}

@PendingFeature(reason = 'helperService is null')
void 'some test method'() {
expect:
helperService != null
}

@PendingFeature(reason = 'helperService is null')
void 'some other test method'() {
expect:
helperService != null
Expand Down
2 changes: 0 additions & 2 deletions examples/demo33/src/test/groovy/demo/CarServiceSpec.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ package demo

import grails.testing.gorm.DataTest
import grails.testing.services.ServiceUnitTest
import spock.lang.Ignore
import spock.lang.Specification

@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class CarServiceSpec extends Specification implements ServiceUnitTest<CarService>, DataTest{

void setupSpec() {
Expand Down
2 changes: 0 additions & 2 deletions examples/demo33/src/test/groovy/demo/CarSpec.groovy
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package demo

import grails.testing.gorm.DomainUnitTest
import spock.lang.Ignore
import spock.lang.Specification

@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class CarSpec extends Specification implements DomainUnitTest<Car> {

def setup() {
Expand Down
2 changes: 0 additions & 2 deletions examples/demo33/src/test/groovy/demo/DataTestTraitSpec.groovy
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package demo

import grails.testing.gorm.DataTest
import spock.lang.Ignore
import spock.lang.Specification

@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class DataTestTraitSpec extends Specification implements DataTest {

void setupSpec() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package demo

import grails.testing.gorm.DataTest
import spock.lang.Ignore
import spock.lang.Specification

@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class GetDomainClassesToMockMethodSpec extends Specification implements DataTest {

Class[] getDomainClassesToMock() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ package demo

import grails.testing.gorm.DataTest
import grails.testing.web.controllers.ControllerUnitTest
import spock.lang.Ignore
import spock.lang.Specification

@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class PersonControllerSpec extends Specification implements ControllerUnitTest<PersonController>, DataTest {

void setupSpec() {
Expand Down
2 changes: 0 additions & 2 deletions examples/demo33/src/test/groovy/demo/PersonServiceSpec.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@ package demo

import grails.testing.gorm.DataTest
import grails.testing.services.ServiceUnitTest
import spock.lang.Ignore
import spock.lang.Issue
import spock.lang.Specification

@Issue('grails/grails-testing-support#18')
@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class PersonServiceSpec extends Specification implements ServiceUnitTest<PersonService>, DataTest {

void setupSpec() {
Expand Down
2 changes: 0 additions & 2 deletions examples/demo33/src/test/groovy/demo/PersonSpec.groovy
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
package demo

import grails.testing.gorm.DomainUnitTest
import spock.lang.Ignore
import spock.lang.Shared
import spock.lang.Specification
import spock.lang.Stepwise

@Stepwise
@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class PersonSpec extends Specification implements DomainUnitTest<Person> {

@Shared int id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ package demo
import grails.persistence.Entity
import grails.testing.gorm.DataTest
import groovy.test.NotYetImplemented
import spock.lang.Ignore
import spock.lang.Specification

@Ignore('Cannot invoke "org.grails.orm.hibernate.HibernateGormEnhancer.registerEntity(org.grails.datastore.mapping.model.PersistentEntity)" because "this.this$0.gormEnhancer" is null')
class UniqueConstraintOnHasOneSpec extends Specification implements DataTest {

void setupSpec() {
Expand Down

0 comments on commit 0eced77

Please sign in to comment.