Add reason for failure to @ignore and @PendingFeature annotations

grails · Sep 29, 2024 · 680d648 · 680d648
1 parent c1a81eb
commit 680d648
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/grails-core/src/test/groovy/org/grails/config/PropertySourcesConfigSpec.groovy b/grails-core/src/test/groovy/org/grails/config/PropertySourcesConfigSpec.groovy
@@ -100,7 +100,7 @@ class PropertySourcesConfigSpec extends Specification {
       test pass.
 
      */
-    @Ignore
+    @Ignore("Cannot set property 'bar' on null object")
     @Issue('grails/grails-core#10188')
     void 'test replacing nested property values'() {
         given: 'a PropertySourcesConfig'

diff --git a/grails-databinding/src/test/groovy/grails/databinding/SimpleDataBinderSpec.groovy b/grails-databinding/src/test/groovy/grails/databinding/SimpleDataBinderSpec.groovy
@@ -19,8 +19,8 @@ import grails.databinding.errors.BindingError
 import grails.databinding.events.DataBindingListenerAdapter
 import org.grails.databinding.converters.DateConversionHelper
 import org.grails.databinding.converters.LocalDateTimeConverter
-import spock.lang.Ignore
 import spock.lang.Issue
+import spock.lang.PendingFeature
 import spock.lang.Specification
 
 import java.text.SimpleDateFormat
@@ -56,7 +56,7 @@ class SimpleDataBinderSpec extends Specification {
         g.gamma == 3
     }
 
-    @Ignore
+    @PendingFeature(reason = 'gadget is null')
     void 'Test binding to nested properties with dotted path syntax'() {
         given:
         def binder = new SimpleDataBinder()

diff --git a/grails-shell/src/test/groovy/org/grails/cli/profile/repository/MavenRepositorySpec.groovy b/grails-shell/src/test/groovy/org/grails/cli/profile/repository/MavenRepositorySpec.groovy
@@ -10,7 +10,7 @@ import spock.lang.Specification
  */
 class MavenRepositorySpec extends Specification {
 
-    @Ignore
+    @Ignore("Could not find artifact org.grails:grails-bom:pom: in grailsCentral (https://repo.grails.org/grails/core)")
     void "Test resolve profile"() {
         given:"A maven profile repository"
         def repo = new MavenProfileRepository()
@@ -23,7 +23,7 @@ class MavenRepositorySpec extends Specification {
         profile.name == 'web'
     }
 
-    @Ignore
+    @Ignore("The following artifacts could not be resolved: org.grails:grails-bom:pom: (absent): Could not find artifact org.grails:grails-bom:pom: in grailsCentral (https://repo.grails.org/grails/core)")
     void "Test list all profiles"() {
         given:"A maven profile repository"
         def repo = new MavenProfileRepository()

diff --git a/...uite-uber/src/test/groovy/grails/compiler/GrailsCompileStaticCompilationErrorsSpec.groovy b/...uite-uber/src/test/groovy/grails/compiler/GrailsCompileStaticCompilationErrorsSpec.groovy
@@ -83,7 +83,7 @@ class GrailsCompileStaticCompilationErrorsSpec extends Specification {
         e.message.contains 'Cannot query on property "town"'
     }
 
-    @Ignore
+    @Ignore("Expected exception of type 'org.codehaus.groovy.control.MultipleCompilationErrorsException', but no exception was thrown")
     @Issue(['GRAILS-11056', 'GRAILS-11057'])
     void 'Test compiling a dynamic finder call with the wrong number of arguments'() {
         given: