Feat: add browser check validations (frontend) #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Bumps [fast-loops](https://github.com/robinweser/fast-loops) from 1.1.3 to 1.1.4. - [Commits](https://github.com/robinweser/fast-loops/commits) --- updated-dependencies: - dependency-name: fast-loops dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
VikaCep
force-pushed
the
feat/browser-check-validations
branch
from
945efbf
to
ccb8d20
Compare
|
@ckbedwell regarding tests, I'd rather add them after porting your form refactor changes into this branch as you implemented a test framework that I think will facilitate writing them here. Let me know if you disagree though. |
ckbedwell
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Super minor comment but otherwise this is great work! I've tried to break it and haven't managed yet. 👏👏👏
Not for this PR but I did notice the validation gets triggered like four or five times on a single character press but it doesn't make any discernible UX impact.
Also not for this PR but I know acorn is relatively big so at some point in the future we can look at lazy loading it as it is only needed for a very specific part of the application.
Merged
VikaCep
added a commit
that referenced
this pull request
Jul 23, 2024
* feat: initial browser check setup * Feat: add browser check validations (frontend) (#869) * chore(deps): bump fast-loops from 1.1.3 to 1.1.4 (#858) Bumps [fast-loops](https://github.com/robinweser/fast-loops) from 1.1.3 to 1.1.4. - [Commits](https://github.com/robinweser/fast-loops/commits) --- updated-dependencies: - dependency-name: fast-loops dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: add acorn for script parsing * feat: parse script and allow to extract options / import statements * feat: add script validations to its own file * feat: apply browser and script validations to form * chore: fix acorn version --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add hover/focus-visible interaction to form sidebar buttons (#871) * fix: fix rendering of scripted checks (#872) * feat: add support for browser checks with new form approach * fix: fix rendering browser checks * fix: display browser checks in its own group * fix: include correct form elements in browser checks * feat: add browser check tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Virginia Cepeda <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Virginia Cepeda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
acornlibrary, the script from both the browser and scripted checks is parsed to make sure that it contains thebrowserimport (fromk6/browser) for browser checks, and validate that it is not present in scripted checks.It also validates the script exports the
optionsconfiguration in browser checks.Frontend part of #864
Browser:
Valid scripts
Not importing browser from
k6/browserNot exporting options
Scripted check:
Valid script:
Importing browser:
