Add ipv6 support #26
Merged
Add ipv6 support #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: Robert Fratto <[email protected]>
tpaschalis
reviewed
Aug 29, 2023
tpaschalis
reviewed
Aug 29, 2023
tpaschalis
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
LGTM, will merge this later today to let @rfratto take a look.
(Let's just run go mod tidy to get rid of extra noise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is inspired from the one in dskit with a few twists to match our case.
Given a list of interfaces the code will return the best IP it can find.
Best is defined in the following order:
Instead of sending a list of interfaces, the user can send "all" and the code will retrieve all available interfaces and find the best IP amongst these.