Merge Bitcamp 2020 Work #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling in Technica changes
Adding docker build for frontend
Correct the number of sponsors is displayed on Admin page
Font-Awesome Updated to v5
Adding github actions for tests and style
The newer 'hooks' syntax for React opts for components as functions, rather than as classes. For stateless components, this makes a lot more sense. For stateful components, there are more considerations, but generally hooks allow for greater code re-use between components and events. This change convers some of the 'low hanging fruit' (i.e., mostly stateless components) to the new hooks syntax.
* More big refactoring * Changed api Dockerfile python version to fix issues * Renamed a ton of instances of "class" to "className" * Created a generic Modal and update several spots to use it * Still room for improvement here * Replaced many instances of <Fragment></Fragement> with null * Use <Card> in AdminProject * Update how editProjectModal is created and rendered * Rewrite Checkbox component * Rewrite editProjectModal, createSponsorModal, and createChallengeModal with React hooks * Replace much of WarningModal with GenericConfirmationModal * Start cleanup of prop id names (modalId, createId, editId, etc -> id) * Delete some unused? FA imports * Rewrite Admin comp. with React hooks * Fix ESLint errors * Rewrite SubmitModal w/ React Hooks * Cleanup some insane checkbox code * Use Card in AdminSponsor; toggle body in better way * editID, createID -> id
|
I think this fixes the following, you'd want to double check:
|
* added useWindowWidth(), replaced all this.state.innerWidth with it * other classes to components, where easy to do
Update titles to Bitcamp
Changed lot of frontend for expo app
Expo Scheduling
Update year and name throughout code
Fix search on admin page
New Table Assignment
Sumit/challenge filter show times
add filter for virtual submissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of commits, along with some recommendations for further work
Some things I would recommend:
Best of luck for Technica 2020!