Cara's First PR #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cara_murphy/art.html
Outdated
| <a href="resume.html"> | ||
| <div class="tab" id="leftTab"> |
There was a problem hiding this comment.
The convention is dashes and not camelcase for classes and IDs.
There was a problem hiding this comment.
Please change this throughout your project.
cara_murphy/art.html
Outdated
| </div> | ||
|
|
||
| <script>function openPage(pageName, element) { | ||
| // Hide all elements with class="imageGrid" by default */ |
cara_murphy/art.html
Outdated
| var sticker, nft, other, shown; | ||
| sticker = document.getElementsByClassName("sticker"); | ||
| nft = document.getElementsByClassName("nft"); | ||
| other = document.getElementsByClassName("other"); |
There was a problem hiding this comment.
Cool to see you adding JavaScript in here! If the JavaScript tends to be more than just a couple lines, move it to a new JS file and link it like we showed in class. So please do that here.
| </div> | ||
| </div> | ||
| </div> | ||
|
|
mirandasong24
requested changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.