Implement some css function, most notably attr()
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now can use the
attr()function, and it will be resolved during selector matching.With this we can support the
bgcolorattribute which is frequently used on the hacker news website.After this PR https://news.ycombinator.com looks like this in gosub:
Best notably is that if we wanted to load the website before, we were just seeing a black screen. If you changed the background color or the default text color, you could see text vertically stacked, so it wasn't even reassembling the layout of it.
We currently also don't support tables, so all the tables on the site are broken, but it still looks quite okay.
I've also started to begin implementing CSS variables, however I want to wait for #582 to be merged, because it changes so much about the node type.
Previously, we were skipping the user agent stylesheet, because it was so large and with an older version of the syntax matcher it took ages to validate.