-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite resampler #166
Merged
Merged
Rewrite resampler #166
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5e1638c - Browse repository at this point
Copy the full SHA 5e1638cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7301df4 - Browse repository at this point
Copy the full SHA 7301df4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d1c089 - Browse repository at this point
Copy the full SHA 3d1c089View commit details -
Revert resampler pts length increase
The original length of pts made sense because when wantPos is a decimal position like 3.5, you want the window for quality 1 to contain positions 3 and 4. Having a window of 1 more doesn't make sense for that. My previous reasoning for increasing the window size was arguing from the point of wantPosition always being an integer value, which isn't the case.
Configuration menu - View commit details
-
Copy full SHA for 79137fc - Browse repository at this point
Copy the full SHA 79137fcView commit details -
Two bugs: - SetRatio() could cause out of range panic when the ratio was sufficiently big. This happens when the newly calculated position was casted to an int. This caused the value to be rounded down. If difference times the ratio was bigger than the buffer, the calculated wantPos could be a negative index in buf1. - When the ratio is sufficiently big, the Stream function may not only need to fill the buffers with new data once, but multiple times. The if statement has been replaced with a for loop, so the check is executed until the desired samples are reached.
Configuration menu - View commit details
-
Copy full SHA for 7ea20bc - Browse repository at this point
Copy the full SHA 7ea20bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0705855 - Browse repository at this point
Copy the full SHA 0705855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fbcee9 - Browse repository at this point
Copy the full SHA 6fbcee9View commit details
Commits on Jul 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for df94d52 - Browse repository at this point
Copy the full SHA df94d52View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.